Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools/ci/checkpatch: add cmake style check into ci-check #9849

Merged
merged 1 commit into from
Jul 18, 2023
Merged

tools/ci/checkpatch: add cmake style check into ci-check #9849

merged 1 commit into from
Jul 18, 2023

Conversation

anchao
Copy link
Contributor

@anchao anchao commented Jul 18, 2023

Summary

tools/ci/checkpatch: add cmake style check into ci-check

Impact

N/A

Testing

run checkpatch for cmake file

/nuttx$ ./tools/checkpatch.sh -g HEAD~1
ERROR __main__.py:618: Check failed: /home/archer/code/nuttx/n10/nuttx/CMakeLists.txt

cmake-format check failed, run following command to update the style:
  $ cmake-format -o /home/archer/code/nuttx/n10/nuttx/CMakeLists.txt /home/archer/code/nuttx/n10/nuttx/CMakeLists.txt

@acassis acassis merged commit 7eff229 into apache:master Jul 18, 2023
@raiden00pl
Copy link
Contributor

@anchao could you look at this https://github.com/apache/nuttx-apps/actions/runs/5597303814/jobs/10235475294?pr=1846

CI check fails with:

cmake-format not found, run following command to install:
15
$ pip install cmake-format

@anchao
Copy link
Contributor Author

anchao commented Jul 20, 2023

@anchao could you look at this https://github.com/apache/nuttx-apps/actions/runs/5597303814/jobs/10235475294?pr=1846

emm... seems like docker is not updated properly, let me check further

@anchao
Copy link
Contributor Author

anchao commented Jul 20, 2023

emm... seems like docker is not updated properly, let me check further

@raiden00pl Since this commit did not pass the CI check, so the docker was not updated, I touched the docker file in PR #9862 , let's wait for the ci finish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anchao @raiden00pl @acassis